Update and improve help info logs #10081
Conversation
vegegoku
force-pushed
the
helpinfo-update-test
branch
from
0d70267 to
c6beedc
Compare
dev/core/src/com/google/gwt/dev/javac/JSORestrictionsChecker.java
Outdated
Show resolved
Hide resolved
dev/core/src/com/google/gwt/dev/util/GwtprojectOrgHelpInfo.java
Outdated
Show resolved
Hide resolved
vegegoku
force-pushed
the
helpinfo-update-test
branch
3 times, most recently
from
8c6ec73 to
e88410f
Compare
vegegoku
force-pushed
the
helpinfo-update-test
branch
from
e88410f to
ecbb8d5
Compare
niloc132
added
the
ready
|
|
||
| public GwtprojectOrgHelpInfo(String relativeUrl) { | ||
| try { | ||
| url = new URL("https://gwtproject.org/doc/latest/gwt-dev-help/" + relativeUrl); |
There was a problem hiding this comment.
Should we append ?version=2.13 as per Colin's suggestion in the issue description?
There was a problem hiding this comment.
I think i'd vote an anchor rather than queryparam, since an anchor will work with just plain html, we won't need custom routing or whatever. On the other hand, if we add JS that helps handle this, we can read either queryparam or anchor?
Probably can most easily do this with About.getGwtVersion().
There was a problem hiding this comment.
With queryparam we could link to
https://www.gwtproject.org/doc/latest/DevGuideCodingBasicsJSNI.html#important (if we wanted tod)
directly by inserting the version param before the #. Also queryparam shows in server logs if you want to check how these pages are used. Both of these possible advantages are hypothetical and come at a cost of adding a bit of JS 🤷
3 participants
Update, migrate, improve log help links
Fix #10042
See also gwtproject/gwt-site#386